Skip to content

feat(DateTimePicker): add Color parameter #6342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

feat(DateTimePicker): add Color parameter #6342

merged 2 commits into from
Jul 2, 2025

Conversation

@Mydashixiong
Copy link
Collaborator

@Mydashixiong Mydashixiong commented Jul 2, 2025 •
edited by ArgoZhang
Loading

Link issues

fixes #6343

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Introduce a new Color parameter for DateTimePicker to set border color style with a default of None

@Mydashixiong
feat(DateTimePicker):DateTimePicker增加Color样式属性
2561de8 
DateTimePicker增加Color样式属性，默认Color.None
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 2, 2025 •
edited
Loading

Reviewer's Guide

Introduces a new Color parameter to the DateTimePicker component and integrates it into the CSS builder to conditionally apply border color classes based on the selected Color value.

File-Level Changes

Change Details Files
Added Color parameter for custom border styling
  • Declare new [Parameter] property 'Color' with default 'Color.None'
  • Update InputClassName logic to include 'border-{Color}' CSS class when Color is set and component is enabled/valid
 src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.cs
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto
Copy link

bb-auto bot commented Jul 2, 2025

Thanks for your PR, @Mydashixiong. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang July 2, 2025 04:02
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mydashixiong - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a408e98) to head (19f7dfa).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #6342   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          717       717           
  Lines        31571     31573    +2     
  Branches      4461      4462    +1     
=========================================
+ Hits         31571     31573    +2
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title feat(DateTimePicker):DateTimePicker增加Color样式属性 feat(DateTimePicker): DateTimePicker增加Color样式属性 Jul 2, 2025
@ArgoZhang ArgoZhang changed the title feat(DateTimePicker): DateTimePicker增加Color样式属性 feat(DateTimePicker): add Color parameter Jul 2, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label Jul 2, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 2, 2025
@ArgoZhang ArgoZhang merged commit 37db88a into main Jul 2, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the DateTimePickerAddColor branch July 2, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@ArgoZhang ArgoZhang Awaiting requested review from ArgoZhang

Assignees

@ArgoZhang ArgoZhang

Labels

enhancement New feature or request

Projects

None yet

Milestone

v9.8.0

Development

Successfully merging this pull request may close these issues.

feat(DateTimePicker): add Color parameter

3 participants

@Mydashixiong @ArgoZhang